Commit 6859e4f2 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Bjorn Helgaas
Browse files

PCI: endpoint: pci-epf-test: Use 'msix_capable' flag directly in pci_epf_test_alloc_space() 



Instead of using a local variable to cache the 'msix_capable' flag, use it
directly to simplify the code.

Suggested-by: default avatarNiklas Cassel <cassel@kernel.org>
Link: https://lore.kernel.org/linux-pci/20240418-pci-epf-test-fix-v2-2-eacd54831444@linaro.org


Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
parent 5a5095a8

drivers/pci/endpoint/functions/pci-epf-test.c

+2 −6
Original line number Diff line number Diff line
@@ -802,19 +802,15 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf) 
	size_t msix_table_size = 0;

	size_t test_reg_bar_size;

	size_t pba_size = 0;

	bool msix_capable;

	void *base;

	enum pci_barno test_reg_bar = epf_test->test_reg_bar;

	enum pci_barno bar;

	const struct pci_epc_features *epc_features;

	const struct pci_epc_features *epc_features = epf_test->epc_features;

	size_t test_reg_size;



	epc_features = epf_test->epc_features;



	test_reg_bar_size = ALIGN(sizeof(struct pci_epf_test_reg), 128);



	msix_capable = epc_features->msix_capable;

	if (msix_capable) {

	if (epc_features->msix_capable) {

		msix_table_size = PCI_MSIX_ENTRY_SIZE * epf->msix_interrupts;

		epf_test->msix_table_offset = test_reg_bar_size;

		/* Align to QWORD or 8 Bytes */