Commit 687f0d0e authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Dmitry Torokhov
Browse files

Input: adp5588 - use new GPIO line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Acked-by: default avatarMichael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/20250610-gpiochip-set-rv-input-v1-2-5875240b48d8@linaro.org


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 4aaadf94

drivers/input/keyboard/adp5588-keys.c

+5 −4
Original line number Diff line number Diff line
@@ -232,8 +232,8 @@ static int adp5588_gpio_get_value(struct gpio_chip *chip, unsigned int off) 
	return !!(val & bit);

}



static void adp5588_gpio_set_value(struct gpio_chip *chip,

				   unsigned int off, int val)

static int adp5588_gpio_set_value(struct gpio_chip *chip, unsigned int off,

				  int val)

{

	struct adp5588_kpad *kpad = gpiochip_get_data(chip);

	unsigned int bank = ADP5588_BANK(kpad->gpiomap[off]);
@@ -246,7 +246,8 @@ static void adp5588_gpio_set_value(struct gpio_chip *chip, 
	else

		kpad->dat_out[bank] &= ~bit;



	adp5588_write(kpad->client, GPIO_DAT_OUT1 + bank, kpad->dat_out[bank]);

	return adp5588_write(kpad->client, GPIO_DAT_OUT1 + bank,

			     kpad->dat_out[bank]);

}



static int adp5588_gpio_set_config(struct gpio_chip *chip,  unsigned int off,
@@ -424,7 +425,7 @@ static int adp5588_gpio_add(struct adp5588_kpad *kpad) 
	kpad->gc.direction_input = adp5588_gpio_direction_input;

	kpad->gc.direction_output = adp5588_gpio_direction_output;

	kpad->gc.get = adp5588_gpio_get_value;

	kpad->gc.set = adp5588_gpio_set_value;

	kpad->gc.set_rv = adp5588_gpio_set_value;

	kpad->gc.set_config = adp5588_gpio_set_config;

	kpad->gc.can_sleep = 1;