Commit 68951e9c authored by Tvrtko Ursulin's avatar Tvrtko Ursulin Committed by Alex Deucher
Browse files

drm/amdgpu/userq: Fix reference leak in amdgpu_userq_wait_ioctl 



Drop reference to syncobj and timeline fence when aborting the ioctl due
output array being too small.

Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Fixes: a292fdec ("drm/amdgpu: Implement userqueue signal/wait IOCTL")
Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 6fde4192

drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c

+2 −0
Original line number Diff line number Diff line
@@ -877,6 +877,7 @@ int amdgpu_userq_wait_ioctl(struct drm_device *dev, void *data, 
				dma_fence_unwrap_for_each(f, &iter, fence) {

					if (WARN_ON_ONCE(num_fences >= wait_info->num_fences)) {

						r = -EINVAL;

						dma_fence_put(fence);

						goto free_fences;

					}
@@ -901,6 +902,7 @@ int amdgpu_userq_wait_ioctl(struct drm_device *dev, void *data, 


			if (WARN_ON_ONCE(num_fences >= wait_info->num_fences)) {

				r = -EINVAL;

				dma_fence_put(fence);

				goto free_fences;

			}