Commit 689a930b authored by David Gow's avatar David Gow Committed by Shuah Khan
Browse files

drm/xe/tests: Fix printf format specifiers in xe_migrate test 



KUNIT_FAIL() is used to fail the xe_migrate test when an error occurs.
However, there's a mismatch in the format specifier: '%li' is used to
log 'err', which is an 'int'.

Use '%i' instead of '%li', and for the case where we're printing an
error pointer, just use '%pe', instead of extracting the error code
manually with PTR_ERR(). (This also results in a nicer output when the
error code is known.)

Fixes: dd08ebf6 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: default avatarDavid Gow <davidgow@google.com>
Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Acked-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent ff3b96f2

drivers/gpu/drm/xe/tests/xe_migrate.c

+4 −4
Original line number Diff line number Diff line
@@ -114,21 +114,21 @@ static void test_copy(struct xe_migrate *m, struct xe_bo *bo, 
						   region |

						   XE_BO_NEEDS_CPU_ACCESS);

	if (IS_ERR(remote)) {

		KUNIT_FAIL(test, "Failed to allocate remote bo for %s: %li\n",

			   str, PTR_ERR(remote));

		KUNIT_FAIL(test, "Failed to allocate remote bo for %s: %pe\n",

			   str, remote);

		return;

	}



	err = xe_bo_validate(remote, NULL, false);

	if (err) {

		KUNIT_FAIL(test, "Failed to validate system bo for %s: %li\n",

		KUNIT_FAIL(test, "Failed to validate system bo for %s: %i\n",

			   str, err);

		goto out_unlock;

	}



	err = xe_bo_vmap(remote);

	if (err) {

		KUNIT_FAIL(test, "Failed to vmap system bo for %s: %li\n",

		KUNIT_FAIL(test, "Failed to vmap system bo for %s: %i\n",

			   str, err);

		goto out_unlock;

	}