Commit 68c51db3 authored by Marcin Szycik's avatar Marcin Szycik Committed by Tony Nguyen
Browse files

ice: Fix VF-VF direction matching in drop rule in switchdev 



When adding a drop rule on a VF, rule direction is not being set, which
results in it always being set to ingress (ICE_ESWITCH_FLTR_INGRESS
equals 0). Because of this, drop rules added on port representors don't
match any packets.

To fix it, set rule direction in drop action to egress when netdev is a
port representor, otherwise set it to ingress.

Fixes: 0960a27b ("ice: Add direction metadata")
Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: default avatarMarcin Szycik <marcin.szycik@linux.intel.com>
Tested-by: default avatarSujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 8b3c8c55

drivers/net/ethernet/intel/ice/ice_tc_lib.c

+23 −1
Original line number Diff line number Diff line
@@ -670,6 +670,25 @@ static int ice_tc_setup_redirect_action(struct net_device *filter_dev, 
	return 0;

}



static int

ice_tc_setup_drop_action(struct net_device *filter_dev,

			 struct ice_tc_flower_fltr *fltr)

{

	fltr->action.fltr_act = ICE_DROP_PACKET;



	if (ice_is_port_repr_netdev(filter_dev)) {

		fltr->direction = ICE_ESWITCH_FLTR_EGRESS;

	} else if (ice_tc_is_dev_uplink(filter_dev)) {

		fltr->direction = ICE_ESWITCH_FLTR_INGRESS;

	} else {

		NL_SET_ERR_MSG_MOD(fltr->extack,

				   "Unsupported netdevice in switchdev mode");

		return -EINVAL;

	}



	return 0;

}



static int ice_eswitch_tc_parse_action(struct net_device *filter_dev,

				       struct ice_tc_flower_fltr *fltr,

				       struct flow_action_entry *act)
@@ -678,7 +697,10 @@ static int ice_eswitch_tc_parse_action(struct net_device *filter_dev, 


	switch (act->id) {

	case FLOW_ACTION_DROP:

		fltr->action.fltr_act = ICE_DROP_PACKET;

		err = ice_tc_setup_drop_action(filter_dev, fltr);

		if (err)

			return err;



		break;



	case FLOW_ACTION_REDIRECT: