Commit 68decaf2 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Mathieu Poirier
Browse files

rpmsg: virtio: Remove uncallable offchannel functions 



The virtio_rpmsg_send_offchannel() and virtio_rpmsg_trysend_offchannel()
are wired up to the send_offchannel and trysend_offchannel members
of rpmsg_endpoint_ops, the only dereference of those was by
the unused, and now removed rpmsg_send_offchannel() and
rpmsg_trysend_offchannel() functions.

Remove them.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Acked-by: default avatarArnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Link: https://lore.kernel.org/r/20250429234600.301083-3-linux@treblig.org


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 20b4f0b4

drivers/rpmsg/virtio_rpmsg_bus.c

+1 −23
Original line number Diff line number Diff line
@@ -141,13 +141,9 @@ static void virtio_rpmsg_destroy_ept(struct rpmsg_endpoint *ept); 
static int virtio_rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len);

static int virtio_rpmsg_sendto(struct rpmsg_endpoint *ept, void *data, int len,

			       u32 dst);

static int virtio_rpmsg_send_offchannel(struct rpmsg_endpoint *ept, u32 src,

					u32 dst, void *data, int len);

static int virtio_rpmsg_trysend(struct rpmsg_endpoint *ept, void *data, int len);

static int virtio_rpmsg_trysendto(struct rpmsg_endpoint *ept, void *data,

				  int len, u32 dst);

static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src,

					   u32 dst, void *data, int len);

static ssize_t virtio_rpmsg_get_mtu(struct rpmsg_endpoint *ept);

static struct rpmsg_device *__rpmsg_create_channel(struct virtproc_info *vrp,

						   struct rpmsg_channel_info *chinfo);
@@ -156,10 +152,8 @@ static const struct rpmsg_endpoint_ops virtio_endpoint_ops = { 
	.destroy_ept = virtio_rpmsg_destroy_ept,

	.send = virtio_rpmsg_send,

	.sendto = virtio_rpmsg_sendto,

	.send_offchannel = virtio_rpmsg_send_offchannel,

	.trysend = virtio_rpmsg_trysend,

	.trysendto = virtio_rpmsg_trysendto,

	.trysend_offchannel = virtio_rpmsg_trysend_offchannel,

	.get_mtu = virtio_rpmsg_get_mtu,

};
@@ -545,7 +539,7 @@ static void rpmsg_downref_sleepers(struct virtproc_info *vrp) 
 * the function will immediately fail, and -ENOMEM will be returned.

 *

 * Normally drivers shouldn't use this function directly; instead, drivers

 * should use the appropriate rpmsg_{try}send{to, _offchannel} API

 * should use the appropriate rpmsg_{try}send{to} API

 * (see include/linux/rpmsg.h).

 *

 * Return: 0 on success and an appropriate error value on failure.
@@ -665,14 +659,6 @@ static int virtio_rpmsg_sendto(struct rpmsg_endpoint *ept, void *data, int len, 
	return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, true);

}



static int virtio_rpmsg_send_offchannel(struct rpmsg_endpoint *ept, u32 src,

					u32 dst, void *data, int len)

{

	struct rpmsg_device *rpdev = ept->rpdev;



	return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, true);

}



static int virtio_rpmsg_trysend(struct rpmsg_endpoint *ept, void *data, int len)

{

	struct rpmsg_device *rpdev = ept->rpdev;
@@ -690,14 +676,6 @@ static int virtio_rpmsg_trysendto(struct rpmsg_endpoint *ept, void *data, 
	return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, false);

}



static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src,

					   u32 dst, void *data, int len)

{

	struct rpmsg_device *rpdev = ept->rpdev;



	return rpmsg_send_offchannel_raw(rpdev, src, dst, data, len, false);

}



static ssize_t virtio_rpmsg_get_mtu(struct rpmsg_endpoint *ept)

{

	struct rpmsg_device *rpdev = ept->rpdev;