Commit 68f78c72 authored by Bence Csókás's avatar Bence Csókás Committed by Alexandre Belloni
Browse files

rtc: ds1307: Clamp year to valid BCD (0-99) in `set_time()` 



`tm_year` may go up to 299 if the device supports the
century bit. Therefore, subtracting may not give us
a valid 2-digit number, but modulo does.

Co-developed-by: default avatarSzentendrei, Tamás <szentendrei.tamas@prolan.hu>
Signed-off-by: default avatarSzentendrei, Tamás <szentendrei.tamas@prolan.hu>
Signed-off-by: default avatarCsókás, Bence <csokas.bence@prolan.hu>
Link: https://lore.kernel.org/r/20240611072411.671600-2-csokas.bence@prolan.hu


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 35a34f09

drivers/rtc/rtc-ds1307.c

+1 −1
Original line number Diff line number Diff line
@@ -359,7 +359,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t) 
	regs[DS1307_REG_MONTH] = bin2bcd(t->tm_mon + 1);



	/* assume 20YY not 19YY */

	tmp = t->tm_year - 100;

	tmp = t->tm_year % 100;

	regs[DS1307_REG_YEAR] = bin2bcd(tmp);



	if (chip->century_enable_bit)