Unverified Commit 690aa09b authored by Amadeusz Sławiński's avatar Amadeusz Sławiński Committed by Mark Brown
Browse files

ASoC: Intel: catpt: Expose correct bit depth to userspace 



Currently wrong bit depth is exposed in hw params, causing clipped
volume during playback. Expose correct parameters.

Fixes: a126750f ("ASoC: Intel: catpt: PCM operations")
Reported-by: default avatarAndy Shevchenko <andriy.shevchenko@intel.com>
Tested-by: default avatarAndy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Message-ID: <20250909092829.375953-1-amadeuszx.slawinski@linux.intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bfa4d097

sound/soc/intel/catpt/pcm.c

+17 −6
Original line number Diff line number Diff line
@@ -568,8 +568,9 @@ static const struct snd_pcm_hardware catpt_pcm_hardware = { 
				  SNDRV_PCM_INFO_RESUME |

				  SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,

	.formats		= SNDRV_PCM_FMTBIT_S16_LE |

				  SNDRV_PCM_FMTBIT_S24_LE |

				  SNDRV_PCM_FMTBIT_S32_LE,

	.subformats		= SNDRV_PCM_SUBFMTBIT_MSBITS_24 |

				  SNDRV_PCM_SUBFMTBIT_MSBITS_MAX,

	.period_bytes_min	= PAGE_SIZE,

	.period_bytes_max	= CATPT_BUFFER_MAX_SIZE / CATPT_PCM_PERIODS_MIN,

	.periods_min		= CATPT_PCM_PERIODS_MIN,
@@ -698,14 +699,18 @@ static struct snd_soc_dai_driver dai_drivers[] = { 
		.channels_min = 2,

		.channels_max = 2,

		.rates = SNDRV_PCM_RATE_48000,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE,

		.subformats = SNDRV_PCM_SUBFMTBIT_MSBITS_24 |

			      SNDRV_PCM_SUBFMTBIT_MSBITS_MAX,

	},

	.capture = {

		.stream_name = "Analog Capture",

		.channels_min = 2,

		.channels_max = 4,

		.rates = SNDRV_PCM_RATE_48000,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE,

		.subformats = SNDRV_PCM_SUBFMTBIT_MSBITS_24 |

			      SNDRV_PCM_SUBFMTBIT_MSBITS_MAX,

	},

},

{
@@ -717,7 +722,9 @@ static struct snd_soc_dai_driver dai_drivers[] = { 
		.channels_min = 2,

		.channels_max = 2,

		.rates = SNDRV_PCM_RATE_8000_192000,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE,

		.subformats = SNDRV_PCM_SUBFMTBIT_MSBITS_24 |

			      SNDRV_PCM_SUBFMTBIT_MSBITS_MAX,

	},

},

{
@@ -729,7 +736,9 @@ static struct snd_soc_dai_driver dai_drivers[] = { 
		.channels_min = 2,

		.channels_max = 2,

		.rates = SNDRV_PCM_RATE_8000_192000,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE,

		.subformats = SNDRV_PCM_SUBFMTBIT_MSBITS_24 |

			      SNDRV_PCM_SUBFMTBIT_MSBITS_MAX,

	},

},

{
@@ -741,7 +750,9 @@ static struct snd_soc_dai_driver dai_drivers[] = { 
		.channels_min = 2,

		.channels_max = 2,

		.rates = SNDRV_PCM_RATE_48000,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,

		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE,

		.subformats = SNDRV_PCM_SUBFMTBIT_MSBITS_24 |

			      SNDRV_PCM_SUBFMTBIT_MSBITS_MAX,

	},

},

{