Commit 691a41d8 authored by David Howells's avatar David Howells Committed by Steve French
Browse files

cifs: Fix non-availability of dedup breaking generic/304 



Deduplication isn't supported on cifs, but cifs doesn't reject it, instead
treating it as extent duplication/cloning.  This can cause generic/304 to go
silly and run for hours on end.

Fix cifs to indicate EOPNOTSUPP if REMAP_FILE_DEDUP is set in
->remap_file_range().

Note that it's unclear whether or not commit b073a080 is meant to cause
cifs to return an error if REMAP_FILE_DEDUP.

Fixes: b073a080 ("cifs: fix that return -EINVAL when do dedupe operation")
Cc: stable@vger.kernel.org
Suggested-by: default avatarDave Chinner <david@fromorbit.com>
cc: Xiaoli Feng <fengxiaoli0714@gmail.com>
cc: Shyam Prasad N <nspmangalore@gmail.com>
cc: Rohith Surabattula <rohiths.msft@gmail.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: Darrick Wong <darrick.wong@oracle.com>
cc: fstests@vger.kernel.org
cc: linux-cifs@vger.kernel.org
cc: linux-fsdevel@vger.kernel.org
Link: https://lore.kernel.org/r/3876191.1701555260@warthog.procyon.org.uk/


Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 92414333

fs/smb/client/cifsfs.c

+3 −1
Original line number Diff line number Diff line
@@ -1277,7 +1277,9 @@ static loff_t cifs_remap_file_range(struct file *src_file, loff_t off, 
	unsigned int xid;

	int rc;



	if (remap_flags & ~(REMAP_FILE_DEDUP | REMAP_FILE_ADVISORY))

	if (remap_flags & REMAP_FILE_DEDUP)

		return -EOPNOTSUPP;

	if (remap_flags & ~REMAP_FILE_ADVISORY)

		return -EINVAL;



	cifs_dbg(FYI, "clone range\n");