Commit 692a497e authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: ti_usb_3410_5052: drop bogus read urb check 



The read urb pointer is dereferenced before checking that it is non-NULL
during open(), but no check is needed as the existence of a bulk in
endpoint is verified during attach() since commit ef079936 ("USB:
serial: ti_usb_3410_5052: fix NULL-deref at open").

Drop the bogus read urb sanity check.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent b4432656

drivers/usb/serial/ti_usb_3410_5052.c

+0 −5
Original line number Diff line number Diff line
@@ -729,11 +729,6 @@ static int ti_open(struct tty_struct *tty, struct usb_serial_port *port) 


	/* start read urb */

	urb = port->read_urb;

	if (!urb) {

		dev_err(&port->dev, "%s - no read urb\n", __func__);

		status = -EINVAL;

		goto unlink_int_urb;

	}

	tport->tp_read_urb_state = TI_READ_URB_RUNNING;

	urb->context = tport;

	status = usb_submit_urb(urb, GFP_KERNEL);