Commit 69426c6c authored by Bradford Love's avatar Bradford Love Committed by Hans Verkuil
Browse files

media: cx231xx: Fix AGC levels for NTSC-M 



Windows uses the implemented command sequence to set AGC for NTSC-M.
The previous Linux values work, mostly, but on some embedded
platforms NTSC-M is very unstable. The Windows default values
completely fix any signal stability issues and produce a clear image.

Signed-off-by: default avatarBradford Love <brad@nextdimension.cc>
Signed-off-by: default avatarHans Verkuil <hverkuil+cisco@kernel.org>
parent bad32ae4

drivers/media/usb/cx231xx/cx231xx-avcore.c

+3 −4
Original line number Diff line number Diff line
@@ -2028,9 +2028,8 @@ int cx231xx_dif_set_standard(struct cx231xx *dev, u32 standard) 
						0x000035e8);



		status = vid_blk_write_word(dev, DIF_AGC_CTRL_IF,  0xC2262600);

		status = vid_blk_write_word(dev, DIF_AGC_CTRL_INT,

						0xC2262600);

		status = vid_blk_write_word(dev, DIF_AGC_CTRL_RF, 0xC2262600);

		status = vid_blk_write_word(dev, DIF_AGC_CTRL_INT, 0xC2260000);

		status = vid_blk_write_word(dev, DIF_AGC_CTRL_RF,  0xC2260000);



		/* Save the Spec Inversion value */

		dif_misc_ctrl_value &= FLD_DIF_SPEC_INV;