Commit 6955bfef authored by Namjae Jeon's avatar Namjae Jeon Committed by Steve French
Browse files

ksmbd: use ib_device_get_netdev() instead of calling ops.get_netdev 



ULPs are not supposed to call to ops.* directly.

Suggested-by: default avatarLeon Romanovsky <leon@kernel.org>
Reviewed-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 6171063e

fs/smb/server/transport_rdma.c

+2 −4
Original line number Diff line number Diff line
@@ -2142,8 +2142,7 @@ static int smb_direct_ib_client_add(struct ib_device *ib_dev) 
	if (ib_dev->node_type != RDMA_NODE_IB_CA)

		smb_direct_port = SMB_DIRECT_PORT_IWARP;



	if (!ib_dev->ops.get_netdev ||

	    !rdma_frwr_is_supported(&ib_dev->attrs))

	if (!rdma_frwr_is_supported(&ib_dev->attrs))

		return 0;



	smb_dev = kzalloc(sizeof(*smb_dev), KSMBD_DEFAULT_GFP);
@@ -2243,8 +2242,7 @@ bool ksmbd_rdma_capable_netdev(struct net_device *netdev) 
		for (i = 0; i < smb_dev->ib_dev->phys_port_cnt; i++) {

			struct net_device *ndev;



			ndev = smb_dev->ib_dev->ops.get_netdev(smb_dev->ib_dev,

							       i + 1);

			ndev = ib_device_get_netdev(smb_dev->ib_dev, i + 1);

			if (!ndev)

				continue;