Commit 69909c56 authored by Oleksij Rempel's avatar Oleksij Rempel Committed by Jakub Kicinski
Browse files

net: usb: lan78xx: Use ethtool_op_get_link to reflect current link status 



Replace the custom lan78xx_get_link implementation with the standard
ethtool_op_get_link helper, which uses netif_carrier_ok to reflect
the current link status accurately.

Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/20250618122602.3156678-4-o.rempel@pengutronix.de


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2c7fad8a

drivers/net/usb/lan78xx.c

+1 −13
Original line number Diff line number Diff line
@@ -1839,18 +1839,6 @@ static int lan78xx_set_eee(struct net_device *net, struct ethtool_keee *edata) 
	return ret;

}



static u32 lan78xx_get_link(struct net_device *net)

{

	u32 link;



	mutex_lock(&net->phydev->lock);

	phy_read_status(net->phydev);

	link = net->phydev->link;

	mutex_unlock(&net->phydev->lock);



	return link;

}



static void lan78xx_get_drvinfo(struct net_device *net,

				struct ethtool_drvinfo *info)

{
@@ -1970,7 +1958,7 @@ lan78xx_get_regs(struct net_device *netdev, struct ethtool_regs *regs, 
}



static const struct ethtool_ops lan78xx_ethtool_ops = {

	.get_link	= lan78xx_get_link,

	.get_link	= ethtool_op_get_link,

	.nway_reset	= phy_ethtool_nway_reset,

	.get_drvinfo	= lan78xx_get_drvinfo,

	.get_msglevel	= lan78xx_get_msglevel,