Commit 699fcfb6 authored by Chaitanya Kulkarni's avatar Chaitanya Kulkarni Committed by Jens Axboe
Browse files

md: ignore discard return value 



__blkdev_issue_discard() always returns 0, making all error checking at
call sites dead code.

Simplify md to only check !discard_bio by ignoring the
__blkdev_issue_discard() value.

Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 81e7223b

drivers/md/md.c

+2 −2
Original line number Diff line number Diff line
@@ -9179,8 +9179,8 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev, 
{

	struct bio *discard_bio = NULL;



	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO,

			&discard_bio) || !discard_bio)

	__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, &discard_bio);

	if (!discard_bio)

		return;



	bio_chain(discard_bio, bio);