Commit 69f8e15a authored by Sean Christopherson's avatar Sean Christopherson
Browse files

KVM: selftests: Use the SEV library APIs in the intra-host migration test 



Port the existing intra-host SEV(-ES) migration test to the recently added
SEV library, which handles much of the boilerplate needed to create and
configure SEV guests.

Tested-by: default avatarCarlos Bilbao <carlos.bilbao@amd.com>
Link: https://lore.kernel.org/r/20240223004258.3104051-10-seanjc@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent ae20eef5

tools/testing/selftests/kvm/x86_64/sev_migrate_tests.c

+18 −42
Original line number Diff line number Diff line
@@ -10,11 +10,9 @@ 
#include "test_util.h"

#include "kvm_util.h"

#include "processor.h"

#include "svm_util.h"

#include "sev.h"

#include "kselftest.h"



#define SEV_POLICY_ES 0b100



#define NR_MIGRATE_TEST_VCPUS 4

#define NR_MIGRATE_TEST_VMS 3

#define NR_LOCK_TESTING_THREADS 3
@@ -22,46 +20,24 @@ 


bool have_sev_es;



static int __sev_ioctl(int vm_fd, int cmd_id, void *data, __u32 *fw_error)

{

	struct kvm_sev_cmd cmd = {

		.id = cmd_id,

		.data = (uint64_t)data,

		.sev_fd = open_sev_dev_path_or_exit(),

	};

	int ret;



	ret = ioctl(vm_fd, KVM_MEMORY_ENCRYPT_OP, &cmd);

	*fw_error = cmd.error;

	return ret;

}



static void sev_ioctl(int vm_fd, int cmd_id, void *data)

{

	int ret;

	__u32 fw_error;



	ret = __sev_ioctl(vm_fd, cmd_id, data, &fw_error);

	TEST_ASSERT(ret == 0 && fw_error == SEV_RET_SUCCESS,

		    "%d failed: return code: %d, errno: %d, fw error: %d",

		    cmd_id, ret, errno, fw_error);

}



static struct kvm_vm *sev_vm_create(bool es)

{

	struct kvm_vm *vm;

	struct kvm_sev_launch_start start = { 0 };

	int i;



	vm = vm_create_barebones();

	sev_ioctl(vm->fd, es ? KVM_SEV_ES_INIT : KVM_SEV_INIT, NULL);

	if (!es)

		sev_vm_init(vm);

	else

		sev_es_vm_init(vm);



	for (i = 0; i < NR_MIGRATE_TEST_VCPUS; ++i)

		__vm_vcpu_add(vm, i);



	sev_vm_launch(vm, es ? SEV_POLICY_ES : 0);



	if (es)

		start.policy |= SEV_POLICY_ES;

	sev_ioctl(vm->fd, KVM_SEV_LAUNCH_START, &start);

	if (es)

		sev_ioctl(vm->fd, KVM_SEV_LAUNCH_UPDATE_VMSA, NULL);

		vm_sev_ioctl(vm, KVM_SEV_LAUNCH_UPDATE_VMSA, NULL);

	return vm;

}
@@ -181,7 +157,7 @@ static void test_sev_migrate_parameters(void) 
	sev_vm = sev_vm_create(/* es= */ false);

	sev_es_vm = sev_vm_create(/* es= */ true);

	sev_es_vm_no_vmsa = vm_create_barebones();

	sev_ioctl(sev_es_vm_no_vmsa->fd, KVM_SEV_ES_INIT, NULL);

	sev_es_vm_init(sev_es_vm_no_vmsa);

	__vm_vcpu_add(sev_es_vm_no_vmsa, 1);



	ret = __sev_migrate_from(sev_vm, sev_es_vm);
@@ -230,13 +206,13 @@ static void sev_mirror_create(struct kvm_vm *dst, struct kvm_vm *src) 
	TEST_ASSERT(!ret, "Copying context failed, ret: %d, errno: %d\n", ret, errno);

}



static void verify_mirror_allowed_cmds(int vm_fd)

static void verify_mirror_allowed_cmds(struct kvm_vm *vm)

{

	struct kvm_sev_guest_status status;

	int cmd_id;



	for (int cmd_id = KVM_SEV_INIT; cmd_id < KVM_SEV_NR_MAX; ++cmd_id) {

	for (cmd_id = KVM_SEV_INIT; cmd_id < KVM_SEV_NR_MAX; ++cmd_id) {

		int ret;

		__u32 fw_error;



		/*

		 * These commands are allowed for mirror VMs, all others are
@@ -256,14 +232,14 @@ static void verify_mirror_allowed_cmds(int vm_fd) 
		 * These commands should be disallowed before the data

		 * parameter is examined so NULL is OK here.

		 */

		ret = __sev_ioctl(vm_fd, cmd_id, NULL, &fw_error);

		ret = __vm_sev_ioctl(vm, cmd_id, NULL);

		TEST_ASSERT(

			ret == -1 && errno == EINVAL,

			"Should not be able call command: %d. ret: %d, errno: %d\n",

			cmd_id, ret, errno);

	}



	sev_ioctl(vm_fd, KVM_SEV_GUEST_STATUS, &status);

	vm_sev_ioctl(vm, KVM_SEV_GUEST_STATUS, &status);

}



static void test_sev_mirror(bool es)
@@ -281,9 +257,9 @@ static void test_sev_mirror(bool es) 
		__vm_vcpu_add(dst_vm, i);



	if (es)

		sev_ioctl(dst_vm->fd, KVM_SEV_LAUNCH_UPDATE_VMSA, NULL);

		vm_sev_ioctl(dst_vm, KVM_SEV_LAUNCH_UPDATE_VMSA, NULL);



	verify_mirror_allowed_cmds(dst_vm->fd);

	verify_mirror_allowed_cmds(dst_vm);



	kvm_vm_free(src_vm);

	kvm_vm_free(dst_vm);