Commit 6a06fc77 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: omapfb/sharp-ls037v7dw01: Don't put .remove() in .exit.text and drop suppress_bind_attrs 



On today's platforms the memory savings of putting the remove function
in .exit isn't that relevant any more. It only matters for built-in
drivers and typically saves a few 100k.

The downside is that the driver cannot be unbound at runtime which is
ancient and also slightly complicates testing. Also it requires to mark
the driver struct with __refdata which is needed to suppress a (W=1)
modpost warning:

	WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01: section mismatch in reference: sharp_ls_driver+0x4 (section: .data) -> sharp_ls_remove (section: .exit.text)

To simplify matters, move the remove callback to .text and drop
.suppress_bind_attrs = true.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 7462e460

drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c

+2 −3
Original line number Diff line number Diff line
@@ -292,7 +292,7 @@ static int sharp_ls_probe(struct platform_device *pdev) 
	return r;

}



static int __exit sharp_ls_remove(struct platform_device *pdev)

static int sharp_ls_remove(struct platform_device *pdev)

{

	struct panel_drv_data *ddata = platform_get_drvdata(pdev);

	struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -317,11 +317,10 @@ MODULE_DEVICE_TABLE(of, sharp_ls_of_match); 


static struct platform_driver sharp_ls_driver = {

	.probe = sharp_ls_probe,

	.remove = __exit_p(sharp_ls_remove),

	.remove = sharp_ls_remove,

	.driver = {

		.name = "panel-sharp-ls037v7dw01",

		.of_match_table = sharp_ls_of_match,

		.suppress_bind_attrs = true,

	},

};