Commit 6a13057d authored by Tamir Duberstein's avatar Tamir Duberstein Committed by Miguel Ojeda
Browse files

rust: list: use fully qualified path 



Use a fully qualified path rooted at `$crate` rather than relying on
imports in the invoking scope.

Tested-by: default avatarAlice Ryhl <aliceryhl@google.com>
Reviewed-by: default avatarAlice Ryhl <aliceryhl@google.com>
Signed-off-by: default avatarTamir Duberstein <tamird@gmail.com>
Link: https://lore.kernel.org/r/20250709-list-no-offset-v4-4-a429e75840a9@gmail.com


Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 9e626edd

rust/kernel/list/impl_list_item_mod.rs

+5 −5
Original line number Diff line number Diff line
@@ -4,8 +4,6 @@ 


//! Helpers for implementing list traits safely.



use crate::list::ListLinks;



/// Declares that this type has a `ListLinks<ID>` field at a fixed offset.

///

/// This trait is only used to help implement `ListItem` safely. If `ListItem` is implemented
@@ -27,11 +25,11 @@ pub unsafe trait HasListLinks<const ID: u64 = 0> { 
    ///

    /// The provided pointer must point at a valid struct of type `Self`.

    ///

    /// [`ListLinks<T, ID>`]: ListLinks

    /// [`ListLinks<T, ID>`]: crate::list::ListLinks

    // We don't really need this method, but it's necessary for the implementation of

    // `impl_has_list_links!` to be correct.

    #[inline]

    unsafe fn raw_get_list_links(ptr: *mut Self) -> *mut ListLinks<ID> {

    unsafe fn raw_get_list_links(ptr: *mut Self) -> *mut crate::list::ListLinks<ID> {

        // SAFETY: The caller promises that the pointer is valid. The implementer promises that the

        // `OFFSET` constant is correct.

        unsafe { ptr.cast::<u8>().add(Self::OFFSET).cast() }
@@ -222,7 +220,9 @@ unsafe fn prepare_to_insert(me: *const Self) -> *mut $crate::list::ListLinks<$nu 
            //   this value is not in a list.

            unsafe fn view_links(me: *const Self) -> *mut $crate::list::ListLinks<$num> {

                // SAFETY: The caller promises that `me` points at a valid value of type `Self`.

                unsafe { <Self as HasListLinks<$num>>::raw_get_list_links(me.cast_mut()) }

                unsafe {

                    <Self as $crate::list::HasListLinks<$num>>::raw_get_list_links(me.cast_mut())

                }

            }



            // This function is also used as the implementation of `post_remove`, so the caller