Unverified Commit 6a293b6e authored by Antheas Kapenekakis's avatar Antheas Kapenekakis Committed by Ilpo Järvinen
Browse files

HID: asus: use same report_id in response 



Currently, asus_kbd_get_functions prods the device using feature
report report_id, but then is hardcoded to check the response through
FEATURE_KBD_REPORT_ID. This only works if report_id is that value
(currently true). So, use report_id in the response as well to
maintain functionality if that value changes in the future.

Reviewed-by: default avatarDenis Benato <benato.denis96@gmail.com>
Acked-by: default avatarBenjamin Tissoires <bentiss@kernel.org>
Signed-off-by: default avatarAntheas Kapenekakis <lkml@antheas.dev>
Link: https://patch.msgid.link/20260122075044.5070-4-lkml@antheas.dev


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 4ac51daa

drivers/hid/hid-asus.c

+1 −1
Original line number Diff line number Diff line
@@ -424,7 +424,7 @@ static int asus_kbd_get_functions(struct hid_device *hdev, 
	if (!readbuf)

		return -ENOMEM;



	ret = hid_hw_raw_request(hdev, FEATURE_KBD_REPORT_ID, readbuf,

	ret = hid_hw_raw_request(hdev, report_id, readbuf,

				 FEATURE_KBD_REPORT_SIZE, HID_FEATURE_REPORT,

				 HID_REQ_GET_REPORT);

	if (ret < 0) {