Commit 6a404f47 authored by NeilBrown's avatar NeilBrown Committed by Chuck Lever
Browse files

nfsd: make use of warning provided by refcount_t 



refcount_t, by design, checks for unwanted situations and provides
warnings.  It is rarely useful to have explicit warnings with refcount
usage.

In this case we have an explicit warning if a refcount_t reaches zero
when decremented.  Simply using refcount_dec() will provide a similar
warning and also mark the refcount_t as saturated to avoid any possible
use-after-free.

This patch drops the warning and uses refcount_dec() instead of
refcount_dec_and_test().

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent a2c0412c

fs/nfsd/filecache.c

+1 −1
Original line number Diff line number Diff line
@@ -1050,7 +1050,7 @@ nfsd_file_do_acquire(struct svc_rqst *rqstp, struct net *net, 
		 * the last one however, since we should hold another.

		 */

		if (nfsd_file_lru_remove(nf))

			WARN_ON_ONCE(refcount_dec_and_test(&nf->nf_ref));

			refcount_dec(&nf->nf_ref);

		goto wait_for_construction;

	}