Commit 6a451e2c authored by Baojun Xu's avatar Baojun Xu Committed by Takashi Iwai
Browse files

ALSA: hda/tas2781: Ignore SUBSYS_ID not found for tas2563 projects 



Driver will return error if no SUBSYS_ID found in BIOS(acpi).
It will cause error in tas2563 projects, which have no SUBSYS_ID.

Fixes: 4e7035a7 ("ALSA: hda/tas2781: Add speaker id check for ASUS projects")
Signed-off-by: default avatarBaojun Xu <baojun.xu@ti.com>
Link: https://lore.kernel.org/20241223225442.1358491-1-stuart.a.hayhurst@gmail.com
Link: https://patch.msgid.link/20241230064910.1583-1-baojun.xu@ti.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent b06a6187

sound/pci/hda/tas2781_hda_i2c.c

+4 −0
Original line number Diff line number Diff line
@@ -142,6 +142,9 @@ static int tas2781_read_acpi(struct tasdevice_priv *p, const char *hid) 
	}

	sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));

	if (IS_ERR(sub)) {

		/* No subsys id in older tas2563 projects. */

		if (!strncmp(hid, "INT8866", sizeof("INT8866")))

			goto end_2563;

		dev_err(p->dev, "Failed to get SUBSYS ID.\n");

		ret = PTR_ERR(sub);

		goto err;
@@ -164,6 +167,7 @@ static int tas2781_read_acpi(struct tasdevice_priv *p, const char *hid) 
		p->speaker_id = NULL;

	}



end_2563:

	acpi_dev_free_resource_list(&resources);

	strscpy(p->dev_name, hid, sizeof(p->dev_name));

	put_device(physdev);