Commit 6a4730b3 authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: convert BUG_ON in btrfs_reloc_cow_block() to proper error handling 



This BUG_ON is meant to catch backref cache problems, but these can
arise from either bugs in the backref cache or corruption in the extent
tree.  Fix it to be a proper error.

Reviewed-by: default avatarBoris Burkov <boris@bur.io>
Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 5324c4e1

fs/btrfs/relocation.c

+12 −2
Original line number Diff line number Diff line
@@ -4405,8 +4405,18 @@ int btrfs_reloc_cow_block(struct btrfs_trans_handle *trans, 
		WARN_ON(!first_cow && level == 0);



		node = rc->backref_cache.path[level];

		BUG_ON(node->bytenr != buf->start &&

		       node->new_bytenr != buf->start);



		/*

		 * If node->bytenr != buf->start and node->new_bytenr !=

		 * buf->start then we've got the wrong backref node for what we

		 * expected to see here and the cache is incorrect.

		 */

		if (unlikely(node->bytenr != buf->start && node->new_bytenr != buf->start)) {

			btrfs_err(fs_info,

"bytenr %llu was found but our backref cache was expecting %llu or %llu",

				  buf->start, node->bytenr, node->new_bytenr);

			return -EUCLEAN;

		}



		btrfs_backref_drop_node_buffer(node);

		atomic_inc(&cow->refs);