Commit 6a636d20 authored Sep 25, 2025 by Geert Uytterhoeven

clk: renesas: Use IS_ERR() for pointers that cannot be NULL



The use of IS_ERR_OR_NULL() suggests that "clk" can be a NULL pointer.
Hence smatch assumes so, and issues a "passing zero to 'PTR_ERR'"
warning.

At these checkpoints, "clk" always contains either a valid pointer, or
an error pointer (none of the functions called return NULL pointers).
Hence replace IS_ERR_OR_NULL() by IS_ERR().

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202408032025.ve2JMaoV-lkp@intel.com/


Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://patch.msgid.link/81260328acb5c78e915ab04afad3901a31c16128.1758793709.git.geert+renesas@glider.be

parent 06e6ea35

drivers/clk/renesas/renesas-cpg-mssr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -451,7 +451,7 @@ static void __init cpg_mssr_register_core_clk(const struct cpg_core_clk *core,
		break;
		}

		if (IS_ERR_OR_NULL(clk))
		if (IS_ERR(clk))
		goto fail;

		dev_dbg(dev, "Core clock %pC at %lu Hz\n", clk, clk_get_rate(clk));

drivers/clk/renesas/rzg2l-cpg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1177,7 +1177,7 @@ rzg2l_cpg_register_core_clk(const struct cpg_core_clk *core,
		goto fail;
		}

		if (IS_ERR_OR_NULL(clk))
		if (IS_ERR(clk))
		goto fail;

		dev_dbg(dev, "Core clock %pC at %lu Hz\n", clk, clk_get_rate(clk));

drivers/clk/renesas/rzv2h-cpg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -591,7 +591,7 @@ rzv2h_cpg_register_core_clk(const struct cpg_core_clk *core,
		goto fail;
		}

		if (IS_ERR_OR_NULL(clk))
		if (IS_ERR(clk))
		goto fail;

		dev_dbg(dev, "Core clock %pC at %lu Hz\n", clk, clk_get_rate(clk));