Commit 6a9a52f7 authored by Dawei Li's avatar Dawei Li Committed by Thomas Gleixner
Browse files

irqchip/irq-bcm6345-l1: Avoid explicit cpumask allocation on stack 



In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.

Use cpumask_first_and_and() to avoid the need for a temporary cpumask on
the stack.

Signed-off-by: default avatarDawei Li <dawei.li@shingroup.cn>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240416085454.3547175-3-dawei.li@shingroup.cn
parent cdc66553

drivers/irqchip/irq-bcm6345-l1.c

+1 −5
Original line number Diff line number Diff line
@@ -192,14 +192,10 @@ static int bcm6345_l1_set_affinity(struct irq_data *d, 
	u32 mask = BIT(d->hwirq % IRQS_PER_WORD);

	unsigned int old_cpu = cpu_for_irq(intc, d);

	unsigned int new_cpu;

	struct cpumask valid;

	unsigned long flags;

	bool enabled;



	if (!cpumask_and(&valid, &intc->cpumask, dest))

		return -EINVAL;



	new_cpu = cpumask_any_and(&valid, cpu_online_mask);

	new_cpu = cpumask_first_and_and(&intc->cpumask, dest, cpu_online_mask);

	if (new_cpu >= nr_cpu_ids)

		return -EINVAL;