Commit 6aaa978c authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

RDMA/mana: Fix error unwind in mana_ib_create_qp_rss() 

Sashiko points out that mana_ib_cfg_vport_steering() is leaked, the normal
destroy path cleans it up.

Cc: stable@vger.kernel.org
Fixes: 0266a177 ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
Link: https://sashiko.dev/#/patchset/0-v1-e911b76a94d1%2B65d95-rdma_udata_rep_jgg%40nvidia.com?part=4
Link: https://patch.msgid.link/r/7-v1-41f3135e5565+9d2-rdma_ai_fixes1_jgg@nvidia.com


Reviewed-by: default avatarLong Li <longli@microsoft.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 34ecf795

drivers/infiniband/hw/mana/qp.c

+3 −1
Original line number Diff line number Diff line
@@ -217,13 +217,15 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd *pd, 
		ibdev_dbg(&mdev->ib_dev,

			  "Failed to copy to udata create rss-qp, %d\n",

			  ret);

		goto fail;

		goto err_disable_vport_rx;

	}



	kfree(mana_ind_table);



	return 0;



err_disable_vport_rx:

	mana_disable_vport_rx(mpc);

fail:

	while (i-- > 0) {

		ibwq = ind_tbl->ind_tbl[i];