Commit 6aba0cb5 authored by Anup Patel's avatar Anup Patel Committed by Anup Patel
Browse files

RISC-V: KVM: Fix the size parameter check in SBI SFENCE calls 



As-per the SBI specification, an SBI remote fence operation applies
to the entire address space if either:
1) start_addr and size are both 0
2) size is equal to 2^XLEN-1

>From the above, only #1 is checked by SBI SFENCE calls so fix the
size parameter check in SBI SFENCE calls to cover #2 as well.

Fixes: 13acfec2 ("RISC-V: KVM: Add remote HFENCE functions based on VCPU requests")
Reviewed-by: default avatarAtish Patra <atishp@rivosinc.com>
Signed-off-by: default avatarAnup Patel <apatel@ventanamicro.com>
Link: https://lore.kernel.org/r/20250605061458.196003-2-apatel@ventanamicro.com


Signed-off-by: default avatarAnup Patel <anup@brainfault.org>
parent e04c78d8

arch/riscv/kvm/vcpu_sbi_replace.c

+2 −2
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ static int kvm_sbi_ext_rfence_handler(struct kvm_vcpu *vcpu, struct kvm_run *run 
		kvm_riscv_vcpu_pmu_incr_fw(vcpu, SBI_PMU_FW_FENCE_I_SENT);

		break;

	case SBI_EXT_RFENCE_REMOTE_SFENCE_VMA:

		if (cp->a2 == 0 && cp->a3 == 0)

		if ((cp->a2 == 0 && cp->a3 == 0) || cp->a3 == -1UL)

			kvm_riscv_hfence_vvma_all(vcpu->kvm, hbase, hmask);

		else

			kvm_riscv_hfence_vvma_gva(vcpu->kvm, hbase, hmask,
@@ -111,7 +111,7 @@ static int kvm_sbi_ext_rfence_handler(struct kvm_vcpu *vcpu, struct kvm_run *run 
		kvm_riscv_vcpu_pmu_incr_fw(vcpu, SBI_PMU_FW_HFENCE_VVMA_SENT);

		break;

	case SBI_EXT_RFENCE_REMOTE_SFENCE_VMA_ASID:

		if (cp->a2 == 0 && cp->a3 == 0)

		if ((cp->a2 == 0 && cp->a3 == 0) || cp->a3 == -1UL)

			kvm_riscv_hfence_vvma_asid_all(vcpu->kvm,

						       hbase, hmask, cp->a4);

		else