Commit 6ae7da8e authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Paolo Abeni
Browse files

eth: fbnic: reprogram TCAMs after FW crash 



FW may mess with the TCAM after it boots, to try to restore
the traffic flow to the BMC (it may not be aware that the host
is already up). Make sure that we reprogram the TCAMs after
detecting a crash.

Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20250916231420.1693955-5-kuba@kernel.org


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 504f8b71

drivers/net/ethernet/meta/fbnic/fbnic.h

+2 −0
Original line number Diff line number Diff line
@@ -191,6 +191,8 @@ void fbnic_dbg_fbd_exit(struct fbnic_dev *fbd); 
void fbnic_dbg_init(void);

void fbnic_dbg_exit(void);



void fbnic_rpc_reset_valid_entries(struct fbnic_dev *fbd);



void fbnic_csr_get_regs(struct fbnic_dev *fbd, u32 *data, u32 *regs_version);

int fbnic_csr_regs_len(struct fbnic_dev *fbd);

drivers/net/ethernet/meta/fbnic/fbnic_pci.c

+16 −7
Original line number Diff line number Diff line
@@ -167,6 +167,20 @@ void fbnic_down(struct fbnic_net *fbn) 
	fbnic_flush(fbn);

}



static int fbnic_fw_config_after_crash(struct fbnic_dev *fbd)

{

	if (fbnic_fw_xmit_ownership_msg(fbd, true)) {

		dev_err(fbd->dev, "NIC failed to take ownership\n");



		return -1;

	}



	fbnic_rpc_reset_valid_entries(fbd);

	__fbnic_set_rx_mode(fbd);



	return 0;

}



static void fbnic_health_check(struct fbnic_dev *fbd)

{

	struct fbnic_fw_mbx *tx_mbx = &fbd->mbx[FBNIC_IPC_MBX_TX_IDX];
@@ -182,13 +196,8 @@ static void fbnic_health_check(struct fbnic_dev *fbd) 
	if (tx_mbx->head != tx_mbx->tail)

		return;



	/* TBD: Need to add a more thorough recovery here.

	 *	Specifically I need to verify what all the firmware will have

	 *	changed since we had setup and it rebooted. May just need to

	 *	perform a down/up. For now we will just reclaim ownership so

	 *	the heartbeat can catch the next fault.

	 */

	fbnic_fw_xmit_ownership_msg(fbd, true);

	if (fbnic_fw_config_after_crash(fbd))

		dev_err(fbd->dev, "Firmware recovery failed after crash\n");

}



static void fbnic_service_task(struct work_struct *work)

drivers/net/ethernet/meta/fbnic/fbnic_rpc.c

+21 −0
Original line number Diff line number Diff line
@@ -596,6 +596,21 @@ static void fbnic_clear_macda(struct fbnic_dev *fbd) 
	}

}



static void fbnic_clear_valid_macda(struct fbnic_dev *fbd)

{

	int idx;



	for (idx = ARRAY_SIZE(fbd->mac_addr); idx--;) {

		struct fbnic_mac_addr *mac_addr = &fbd->mac_addr[idx];



		if (mac_addr->state == FBNIC_TCAM_S_VALID) {

			fbnic_clear_macda_entry(fbd, idx);



			mac_addr->state = FBNIC_TCAM_S_UPDATE;

		}

	}

}



static void fbnic_write_macda_entry(struct fbnic_dev *fbd, unsigned int idx,

				    struct fbnic_mac_addr *mac_addr)

{
@@ -1223,3 +1238,9 @@ void fbnic_write_rules(struct fbnic_dev *fbd) 
			fbnic_update_act_tcam(fbd, i);

	}

}



void fbnic_rpc_reset_valid_entries(struct fbnic_dev *fbd)

{

	fbnic_clear_valid_act_tcam(fbd);

	fbnic_clear_valid_macda(fbd);

}