Commit 6afdc60e authored by Jan Kara's avatar Jan Kara
Browse files

udf: Fix inode_getblk() return value 

Smatch noticed that inode_getblk() can return 1 on successful mapping of
a block instead of expected 0 after commit b405c1e5 ("udf: refactor
udf_next_aext() to handle error"). This could confuse some of the
callers and lead to strange failures (although the one reported by
Smatch in udf_mkdir() is impossible to trigger in practice). Fix the
return value of inode_getblk().

Link: https://lore.kernel.org/all/cb514af7-bbe0-435b-934f-dd1d7a16d2cd@stanley.mountain


Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Fixes: b405c1e5 ("udf: refactor udf_next_aext() to handle error")
CC: stable@vger.kernel.org
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent a7624ccd

fs/udf/inode.c

+1 −0
Original line number Diff line number Diff line
@@ -810,6 +810,7 @@ static int inode_getblk(struct inode *inode, struct udf_map_rq *map) 
		}

		map->oflags = UDF_BLK_MAPPED;

		map->pblk = udf_get_lb_pblock(inode->i_sb, &eloc, offset);

		ret = 0;

		goto out_free;

	}