Commit 6b262697 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Christoph Hellwig
Browse files

nvmet-auth: use SHASH_DESC_ON_STACK 



Use SHASH_DESC_ON_STACK to avoid explicit allocation.

Signed-off-by: default avatarHannes Reinecke <hare@kernel.org>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent fee45888

drivers/nvme/target/auth.c

+2 −10
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, 
			 unsigned int shash_len)

{

	struct crypto_shash *shash_tfm;

	struct shash_desc *shash;

	SHASH_DESC_ON_STACK(shash, shash_tfm);

	struct nvmet_ctrl *ctrl = req->sq->ctrl;

	const char *hash_name;

	u8 *challenge = req->sq->dhchap_c1;
@@ -345,19 +345,13 @@ int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, 
						    req->sq->dhchap_c1,

						    challenge, shash_len);

		if (ret)

			goto out_free_challenge;

			goto out;

	}



	pr_debug("ctrl %d qid %d host response seq %u transaction %d\n",

		 ctrl->cntlid, req->sq->qid, req->sq->dhchap_s1,

		 req->sq->dhchap_tid);



	shash = kzalloc(sizeof(*shash) + crypto_shash_descsize(shash_tfm),

			GFP_KERNEL);

	if (!shash) {

		ret = -ENOMEM;

		goto out_free_challenge;

	}

	shash->tfm = shash_tfm;

	ret = crypto_shash_init(shash);

	if (ret)
@@ -392,8 +386,6 @@ int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, 
		goto out;

	ret = crypto_shash_final(shash, response);

out:

	kfree(shash);

out_free_challenge:

	if (challenge != req->sq->dhchap_c1)

		kfree(challenge);

out_free_response: