Commit 6b2c1e30 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Petr Mladek
Browse files

seq_file: Mark binary printing functions with __printf() attribute 



Binary printing functions are using printf() type of format, and compiler
is not happy about them as is:

fs/seq_file.c:418:35: error: function ‘seq_bprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]

Fix the compilation errors by adding __printf() attribute.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarKees Cook <kees@kernel.org>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20250321144822.324050-3-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
parent 079a206f

include/linux/seq_file.h

+1 −0
Original line number Diff line number Diff line
@@ -181,6 +181,7 @@ int seq_open_private(struct file *, const struct seq_operations *, int); 
int seq_release_private(struct inode *, struct file *);



#ifdef CONFIG_BINARY_PRINTF

__printf(2, 0)

void seq_bprintf(struct seq_file *m, const char *f, const u32 *binary);

#endif