Commit 6b2edfba authored Feb 13, 2025 by Heiner Kallweit Committed by Jakub Kicinski Feb 14, 2025

net: phy: remove helper phy_is_internal



Helper phy_is_internal() is just used in two places phylib-internally.
So let's remove it from the API.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/f3f35265-80a9-4ed7-ad78-ae22c21e288b@gmail.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent ef6249e3

drivers/net/phy/phy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -302,7 +302,7 @@ void phy_ethtool_ksettings_get(struct phy_device *phydev,
		cmd->base.port = PORT_BNC;
		else
		cmd->base.port = phydev->port;
		cmd->base.transceiver = phy_is_internal(phydev) ?
		cmd->base.transceiver = phydev->is_internal ?
		XCVR_INTERNAL : XCVR_EXTERNAL;
		cmd->base.phy_address = phydev->mdio.addr;
		cmd->base.autoneg = phydev->autoneg;

drivers/net/phy/phy_device.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -544,7 +544,7 @@ phy_interface_show(struct device dev, struct device_attribute attr, char *buf)
		struct phy_device *phydev = to_phy_device(dev);
		const char *mode = NULL;

		if (phy_is_internal(phydev))
		if (phydev->is_internal)
		mode = "internal";
		else
		mode = phy_modes(phydev->interface);

include/linux/phy.h

+0 −9

Original line number	Diff line number	Diff line
		@@ -1739,15 +1739,6 @@ static inline bool phy_is_default_hwtstamp(struct phy_device *phydev)
		return phy_has_hwtstamp(phydev) && phydev->default_timestamp;
		}

		/**
		* phy_is_internal - Convenience function for testing if a PHY is internal
		* @phydev: the phy_device struct
		*/
		static inline bool phy_is_internal(struct phy_device *phydev)
		{
		return phydev->is_internal;
		}

		/**
		* phy_on_sfp - Convenience function for testing if a PHY is on an SFP module
		* @phydev: the phy_device struct