Unverified Commit 6b4bc145 authored by Hans de Goede's avatar Hans de Goede Committed by Ilpo Järvinen
Browse files

platform/x86: x86-android-tablets: Simplify lenovo_yoga_tab2_830_1050_exit() 



lenovo_yoga_tab2_830_1050_exit() only gets called after a successful
lenovo_yoga_tab2_830_1050_init() call so there is no need to check
if lenovo_yoga_tab2_830_1050_codec_[dev|pinctrl] are set.

Also change the exit() order to be the exact reverse of init().

Reviewed-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarHans de Goede <hansg@kernel.org>
Link: https://patch.msgid.link/20250920200713.20193-19-hansg@kernel.org


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 6564d3e1

drivers/platform/x86/x86-android-tablets/lenovo.c

+4 −9
Original line number Diff line number Diff line
@@ -594,15 +594,10 @@ static void lenovo_yoga_tab2_830_1050_exit(void) 
{

	unregister_sys_off_handler(lenovo_yoga_tab2_830_1050_sys_off_handler);



	if (lenovo_yoga_tab2_830_1050_codec_dev) {

	device_remove_software_node(lenovo_yoga_tab2_830_1050_codec_dev);

		put_device(lenovo_yoga_tab2_830_1050_codec_dev);

	}



	if (lenovo_yoga_tab2_830_1050_codec_pinctrl) {

	pinctrl_put(lenovo_yoga_tab2_830_1050_codec_pinctrl);

	pinctrl_unregister_mappings(&lenovo_yoga_tab2_830_1050_codec_pinctrl_map);

	}

	put_device(lenovo_yoga_tab2_830_1050_codec_dev);

}



/*