Commit 6b94bf97 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

MIPS: alchemy: gpio: use new GPIO line value setter callbacks for the remaining chips 



Previous commit missed two other places that need converting, it only
came out in tests on autobuilders now. Convert the rest of the driver.

Fixes: 68bdc4dc ("MIPS: alchemy: gpio: use new line value setter callbacks")
Acked-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
Link: https://lore.kernel.org/r/20250727082442.13182-1-brgl@bgdev.pl


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent a86240a3

arch/mips/alchemy/common/gpiolib.c

+8 −4
Original line number Diff line number Diff line
@@ -40,9 +40,11 @@ static int gpio2_get(struct gpio_chip *chip, unsigned offset) 
	return !!alchemy_gpio2_get_value(offset + ALCHEMY_GPIO2_BASE);

}



static void gpio2_set(struct gpio_chip *chip, unsigned offset, int value)

static int gpio2_set(struct gpio_chip *chip, unsigned offset, int value)

{

	alchemy_gpio2_set_value(offset + ALCHEMY_GPIO2_BASE, value);



	return 0;

}



static int gpio2_direction_input(struct gpio_chip *chip, unsigned offset)
@@ -68,10 +70,12 @@ static int gpio1_get(struct gpio_chip *chip, unsigned offset) 
	return !!alchemy_gpio1_get_value(offset + ALCHEMY_GPIO1_BASE);

}



static void gpio1_set(struct gpio_chip *chip,

static int gpio1_set(struct gpio_chip *chip,

				unsigned offset, int value)

{

	alchemy_gpio1_set_value(offset + ALCHEMY_GPIO1_BASE, value);



	return 0;

}



static int gpio1_direction_input(struct gpio_chip *chip, unsigned offset)
@@ -97,7 +101,7 @@ struct gpio_chip alchemy_gpio_chip[] = { 
		.direction_input	= gpio1_direction_input,

		.direction_output	= gpio1_direction_output,

		.get			= gpio1_get,

		.set			= gpio1_set,

		.set_rv			= gpio1_set,

		.to_irq			= gpio1_to_irq,

		.base			= ALCHEMY_GPIO1_BASE,

		.ngpio			= ALCHEMY_GPIO1_NUM,
@@ -107,7 +111,7 @@ struct gpio_chip alchemy_gpio_chip[] = { 
		.direction_input	= gpio2_direction_input,

		.direction_output	= gpio2_direction_output,

		.get			= gpio2_get,

		.set			= gpio2_set,

		.set_rv			= gpio2_set,

		.to_irq			= gpio2_to_irq,

		.base			= ALCHEMY_GPIO2_BASE,

		.ngpio			= ALCHEMY_GPIO2_NUM,