Commit 6b9a10d6 authored by John Hubbard's avatar John Hubbard Committed by Danilo Krummrich
Browse files

gpu: nova-core: vbios: use from_le_bytes() for PCI ROM header parsing 



Clippy fires two clippy::precedence warnings on the manual
byte-shifting expression:
  warning: operator precedence can trip the unwary
     --> drivers/gpu/nova-core/vbios.rs:511:17
      |
  511 | /                 u32::from(data[29]) << 24
  512 | |                     | u32::from(data[28]) << 16
  513 | |                     | u32::from(data[27]) << 8
      | |______________________________________________^

Clear the warnings by replacing manual byte-shifting with
u32::from_le_bytes(). Using from_le_bytes() is also a tiny code
improvement, because it uses less code and is clearer about the intent.

Signed-off-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
Link: https://patch.msgid.link/20260404212831.78971-2-jhubbard@nvidia.com


Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
parent de0aca13

drivers/gpu/nova-core/vbios.rs

+1 −6
Original line number Diff line number Diff line
@@ -507,12 +507,7 @@ fn new(dev: &device::Device, data: &[u8]) -> Result<Self> { 


        if data.len() >= 30 {

            // Read size_of_block at offset 0x1A.

            size_of_block = Some(

                u32::from(data[29]) << 24

                    | u32::from(data[28]) << 16

                    | u32::from(data[27]) << 8

                    | u32::from(data[26]),

            );

            size_of_block = Some(u32::from_le_bytes([data[26], data[27], data[28], data[29]]));

        }



        // For NBSI images, try to read the nbsiDataOffset at offset 0x16.