Commit 6b9d2608 authored by Eric Huang's avatar Eric Huang Committed by Alex Deucher
Browse files

drm/amdkfd: fix a bug of smi event for superuser 



rocm-smi with superuser permission doesn't show some
of smi events, i.e. page fault/migration, because the
condition of "(events & all)" is false. Superuser
should be able to detect all events, the condiiton of
"(events & all)" seems redundant, so removing it will
fix the issue.

Signed-off-by: default avatarEric Huang <jinhuieric.huang@amd.com>
Reviewed-by: default avatarKent Russell <kent.russell@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 00ec6732

drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c

+1 −2
Original line number Diff line number Diff line
@@ -163,10 +163,9 @@ static int kfd_smi_ev_release(struct inode *inode, struct file *filep) 
static bool kfd_smi_ev_enabled(pid_t pid, struct kfd_smi_client *client,

			       unsigned int event)

{

	uint64_t all = KFD_SMI_EVENT_MASK_FROM_INDEX(KFD_SMI_EVENT_ALL_PROCESS);

	uint64_t events = READ_ONCE(client->events);



	if (pid && client->pid != pid && !(client->suser && (events & all)))

	if (pid && client->pid != pid && !client->suser)

		return false;



	return events & KFD_SMI_EVENT_MASK_FROM_INDEX(event);