Commit 6bc9f427 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Miquel Raynal
Browse files

mtd: mtdpart: Do not supply NULL to printf() 



GCC compiler is not happy about NULL being supplied as printf() parameter:

drivers/mtd/mtdpart.c:693:34: error: ‘%s’ directive argument is null [-Werror=format-overflow=]

Move the code after the parser test for NULL, and drop the ternary completely.
The user can deduct this since when it's not NULL two messages will be printed.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 2a6a4455

drivers/mtd/mtdpart.c

+1 −2
Original line number Diff line number Diff line
@@ -690,10 +690,9 @@ int parse_mtd_partitions(struct mtd_info *master, const char *const *types, 
			parser = mtd_part_parser_get(*types);

			if (!parser && !request_module("%s", *types))

				parser = mtd_part_parser_get(*types);

			pr_debug("%s: got parser %s\n", master->name,

				parser ? parser->name : NULL);

			if (!parser)

				continue;

			pr_debug("%s: got parser %s\n", master->name, parser->name);

			ret = mtd_part_do_parse(parser, master, &pparts, data);

			if (ret <= 0)

				mtd_part_parser_put(parser);