Commit 6bee9090 authored by Carl Vanderlip's avatar Carl Vanderlip Committed by Jeff Hugo
Browse files

accel/qaic: Use overflow check function instead of division 



Division is an expensive operation. Overflow check functions exist
already. Use existing overflow check functions rather than dividing to
check for overflow.

Signed-off-by: default avatarCarl Vanderlip <quic_carlv@quicinc.com>
Signed-off-by: default avatarYoussef Samir <youssef.abdulrahman@oss.qualcomm.com>
Reviewed-by: default avatarJeff Hugo <jeff.hugo@oss.qualcomm.com>
Reviewed-by: default avatarCarl Vanderlip <carl.vanderlip@oss.qualcomm.com>
Signed-off-by: default avatarJeff Hugo <jeff.hugo@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251007174218.469867-1-youssef.abdulrahman@oss.qualcomm.com
parent 4981c2a0

drivers/accel/qaic/qaic_control.c

+3 −2
Original line number Diff line number Diff line
@@ -656,8 +656,9 @@ static int encode_activate(struct qaic_device *qdev, void *trans, struct wrapper 
		return -EINVAL;



	nelem = in_trans->queue_size;

	size = (get_dbc_req_elem_size() + get_dbc_rsp_elem_size()) * nelem;

	if (size / nelem != get_dbc_req_elem_size() + get_dbc_rsp_elem_size())

	if (check_mul_overflow((u32)(get_dbc_req_elem_size() + get_dbc_rsp_elem_size()),

			       nelem,

			       &size))

		return -EINVAL;



	if (size + QAIC_DBC_Q_GAP + QAIC_DBC_Q_BUF_ALIGN < size)

drivers/accel/qaic/qaic_data.c

+3 −2
Original line number Diff line number Diff line
@@ -982,8 +982,9 @@ int qaic_attach_slice_bo_ioctl(struct drm_device *dev, void *data, struct drm_fi 
	if (args->hdr.count == 0)

		return -EINVAL;



	arg_size = args->hdr.count * sizeof(*slice_ent);

	if (arg_size / args->hdr.count != sizeof(*slice_ent))

	if (check_mul_overflow((unsigned long)args->hdr.count,

			       (unsigned long)sizeof(*slice_ent),

			       &arg_size))

		return -EINVAL;



	if (!(args->hdr.dir == DMA_TO_DEVICE || args->hdr.dir == DMA_FROM_DEVICE))