Commit 6bef98ba authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

nvmem: core: limit cell sysfs permissions to main attribute ones 



The cell sysfs attribute should not provide more access to the nvmem
data than the main attribute itself.
For example if nvme_config::root_only was set, the cell attribute
would still provide read access to everybody.

Mask out permissions not available on the main attribute.

Fixes: 0331c611 ("nvmem: core: Expose cells through sysfs")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20240628113704.13742-5-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0ba424c9

drivers/nvmem/core.c

+1 −1
Original line number Diff line number Diff line
@@ -462,7 +462,7 @@ static int nvmem_populate_sysfs_cells(struct nvmem_device *nvmem) 
						    "%s@%x,%x", entry->name,

						    entry->offset,

						    entry->bit_offset);

		attrs[i].attr.mode = 0444;

		attrs[i].attr.mode = 0444 & nvmem_bin_attr_get_umode(nvmem);

		attrs[i].size = entry->bytes;

		attrs[i].read = &nvmem_cell_attr_read;

		attrs[i].private = entry;