Commit 6c28aa8d authored by Daniel Machon's avatar Daniel Machon Committed by Jakub Kicinski
Browse files

net: sparx5/lan969x: fix DWRR cost max to match hardware register width 



DWRR (Deficit Weighted Round Robin) scheduling distributes bandwidth
across traffic classes based on per-queue cost values, where lower cost
means higher bandwidth share.

The SPX5_DWRR_COST_MAX constant is 63 (6 bits) but the hardware
register field HSCH_DWRR_ENTRY_DWRR_COST is GENMASK(24, 20), only
5 bits wide (max 31). This causes sparx5_weight_to_hw_cost() to
compute cost values that silently overflow via FIELD_PREP, resulting
in incorrect scheduling weights.

Set SPX5_DWRR_COST_MAX to 31 to match the hardware register width.

Fixes: 21122542 ("net: microchip: sparx5: add support for offloading ets qdisc")
Signed-off-by: default avatarDaniel Machon <daniel.machon@microchip.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260210-sparx5-fix-dwrr-cost-max-v1-1-58fbdbc25652@microchip.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 89308781

drivers/net/ethernet/microchip/sparx5/sparx5_qos.h

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ 
#define SPX5_SE_BURST_UNIT 4096



/* Dwrr */

#define SPX5_DWRR_COST_MAX 63

#define SPX5_DWRR_COST_MAX 31



struct sparx5_shaper {

	u32 mode;