Commit 6c4a3fa2 authored by Boris Brezillon's avatar Boris Brezillon
Browse files

drm/panthor: Don't update MMU_INT_MASK in panthor_mmu_irq_handler() 



Interrupts are automatically unmasked in
panthor_mmu_irq_threaded_handler() when the handler returns. Unmasking
prematurely might generate spurious interrupts if the IRQ line is
shared.

Changes in v2:
- New patch

Changes in v3:
- Add R-bs

Reviewed-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/20250404080933.2912674-6-boris.brezillon@collabora.com


Signed-off-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
parent 50b0639b

drivers/gpu/drm/panthor/panthor_mmu.c

+0 −1
Original line number Diff line number Diff line
@@ -1721,7 +1721,6 @@ static void panthor_mmu_irq_handler(struct panthor_device *ptdev, u32 status) 
		 * re-enabled.

		 */

		ptdev->mmu->irq.mask = new_int_mask;

		gpu_write(ptdev, MMU_INT_MASK, new_int_mask);



		if (ptdev->mmu->as.slots[as].vm)

			ptdev->mmu->as.slots[as].vm->unhandled_fault = true;