Unverified Commit 6c960e68 authored by Christian Brauner's avatar Christian Brauner Committed by Christian Brauner (Microsoft)
Browse files

fs: port ->create() to pass mnt_idmap 



Convert to struct mnt_idmap.

Last cycle we merged the necessary infrastructure in
256c8aed ("fs: introduce dedicated idmap type for mounts").
This is just the conversion to struct mnt_idmap.

Currently we still pass around the plain namespace that was attached to a
mount. This is in general pretty convenient but it makes it easy to
conflate namespaces that are relevant on the filesystem with namespaces
that are relevent on the mount level. Especially for non-vfs developers
without detailed knowledge in this area this can be a potential source for
bugs.

Once the conversion to struct mnt_idmap is done all helpers down to the
really low-level helpers will take a struct mnt_idmap argument instead of
two namespace arguments. This way it becomes impossible to conflate the two
eliminating the possibility of any bugs. All of the vfs and all filesystems
only operate on struct mnt_idmap.

Acked-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
parent b74d24f7

Documentation/filesystems/locking.rst

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ inode_operations 


prototypes::



	int (*create) (struct inode *,struct dentry *,umode_t, bool);

	int (*create) (struct mnt_idmap *, struct inode *,struct dentry *,umode_t, bool);

	struct dentry * (*lookup) (struct inode *,struct dentry *, unsigned int);

	int (*link) (struct dentry *,struct inode *,struct dentry *);

	int (*unlink) (struct inode *,struct dentry *);

Documentation/filesystems/vfs.rst

+1 −1
Original line number Diff line number Diff line
@@ -421,7 +421,7 @@ As of kernel 2.6.22, the following members are defined: 
.. code-block:: c



	struct inode_operations {

		int (*create) (struct user_namespace *, struct inode *,struct dentry *, umode_t, bool);

		int (*create) (struct mnt_idmap *, struct inode *,struct dentry *, umode_t, bool);

		struct dentry * (*lookup) (struct inode *,struct dentry *, unsigned int);

		int (*link) (struct dentry *,struct inode *,struct dentry *);

		int (*unlink) (struct inode *,struct dentry *);

fs/9p/vfs_inode.c

+2 −2
Original line number Diff line number Diff line
@@ -672,7 +672,7 @@ v9fs_create(struct v9fs_session_info *v9ses, struct inode *dir, 


/**

 * v9fs_vfs_create - VFS hook to create a regular file

 * @mnt_userns: The user namespace of the mount

 * @idmap: idmap of the mount

 * @dir: The parent directory

 * @dentry: The name of file to be created

 * @mode: The UNIX file mode to set
@@ -684,7 +684,7 @@ v9fs_create(struct v9fs_session_info *v9ses, struct inode *dir, 
 */



static int

v9fs_vfs_create(struct user_namespace *mnt_userns, struct inode *dir,

v9fs_vfs_create(struct mnt_idmap *idmap, struct inode *dir,

		struct dentry *dentry, umode_t mode, bool excl)

{

	struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dir);

fs/9p/vfs_inode_dotl.c

+3 −2
Original line number Diff line number Diff line
@@ -211,7 +211,7 @@ int v9fs_open_to_dotl_flags(int flags) 


/**

 * v9fs_vfs_create_dotl - VFS hook to create files for 9P2000.L protocol.

 * @mnt_userns: The user namespace of the mount

 * @idmap: The user namespace of the mount

 * @dir: directory inode that is being created

 * @dentry:  dentry that is being deleted

 * @omode: create permissions
@@ -219,9 +219,10 @@ int v9fs_open_to_dotl_flags(int flags) 
 *

 */

static int

v9fs_vfs_create_dotl(struct user_namespace *mnt_userns, struct inode *dir,

v9fs_vfs_create_dotl(struct mnt_idmap *idmap, struct inode *dir,

		     struct dentry *dentry, umode_t omode, bool excl)

{

	struct user_namespace *mnt_userns = mnt_idmap_owner(idmap);

	return v9fs_vfs_mknod_dotl(mnt_userns, dir, dentry, omode, 0);

}

fs/affs/affs.h

+1 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ extern const struct export_operations affs_export_ops; 
extern int	affs_hash_name(struct super_block *sb, const u8 *name, unsigned int len);

extern struct dentry *affs_lookup(struct inode *dir, struct dentry *dentry, unsigned int);

extern int	affs_unlink(struct inode *dir, struct dentry *dentry);

extern int	affs_create(struct user_namespace *mnt_userns, struct inode *dir,

extern int	affs_create(struct mnt_idmap *idmap, struct inode *dir,

			struct dentry *dentry, umode_t mode, bool);

extern int	affs_mkdir(struct user_namespace *mnt_userns, struct inode *dir,

			struct dentry *dentry, umode_t mode);