Commit 6cc64f61 authored Sep 09, 2023 by Hans de Goede

gpiolib: acpi: Add a ignore interrupt quirk for Peaq C1010



On the Peaq C1010 2-in-1 INT33FC:00 pin 3 is connected to
a "dolby" button. At the ACPI level an _AEI event-handler
is connected which sets an ACPI variable to 1 on both
edges. This variable can be polled + cleared to 0 using WMI.

Since the variable is set on both edges the WMI interface is pretty
useless even when polling. So instead of writing a custom WMI
driver for this the x86-android-tablets code instantiates
a gpio-keys platform device for the "dolby" button.

Add an ignore_interrupt quirk for INT33FC:00 pin 3 on the Peaq C1010,
so that it is not seen as busy when the gpio-keys driver requests it.

Note this replaces a hack in x86-android-tablets where it would
call acpi_gpiochip_free_interrupts() on the INT33FC:00 GPIO
controller. acpi_gpiochip_free_interrupts() is considered private
(internal) gpiolib API so x86-android-tablets should stop using it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20230909141816.58358-3-hdegoede@redhat.com

parent 5fb36a8c

drivers/gpio/gpiolib-acpi.c

+20 −0

Original line number	Diff line number	Diff line
		@@ -1654,6 +1654,26 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
		.ignore_wake = "SYNA1202:00@16",
		},
		},
		{
		/*
		* On the Peaq C1010 2-in-1 INT33FC:00 pin 3 is connected to
		* a "dolby" button. At the ACPI level an _AEI event-handler
		* is connected which sets an ACPI variable to 1 on both
		* edges. This variable can be polled + cleared to 0 using
		* WMI. But since the variable is set on both edges the WMI
		* interface is pretty useless even when polling.
		* So instead the x86-android-tablets code instantiates
		* a gpio-keys platform device for it.
		* Ignore the _AEI handler for the pin, so that it is not busy.
		*/
		.matches = {
		DMI_MATCH(DMI_SYS_VENDOR, "PEAQ"),
		DMI_MATCH(DMI_PRODUCT_NAME, "PEAQ PMM C1010 MD99187"),
		},
		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
		.ignore_interrupt = "INT33FC:00@3",
		},
		},
		{} /* Terminating entry */
		};