Commit 6cdc4d48 authored by Haotian Zhang's avatar Haotian Zhang Committed by Sebastian Reichel
Browse files

power: supply: rt5033_charger: Fix device node reference leaks 



The device node pointers `np_conn` and `np_edev`, obtained from
of_parse_phandle() and of_get_parent() respectively, are not released.
This results in a reference count leak.

Add of_node_put() calls after the last use of these device nodes to
properly release their references and fix the leaks.

Fixes: 8242336d ("power: supply: rt5033_charger: Add cable detection and USB OTG supply")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20250929113234.1726-1-vulab@iscas.ac.cn


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 1cb053ea

drivers/power/supply/rt5033_charger.c

+2 −0
Original line number Diff line number Diff line
@@ -701,6 +701,8 @@ static int rt5033_charger_probe(struct platform_device *pdev) 
	np_conn = of_parse_phandle(pdev->dev.of_node, "richtek,usb-connector", 0);

	np_edev = of_get_parent(np_conn);

	charger->edev = extcon_find_edev_by_node(np_edev);

	of_node_put(np_edev);

	of_node_put(np_conn);

	if (IS_ERR(charger->edev)) {

		dev_warn(charger->dev, "no extcon device found in device-tree\n");

		goto out;