Commit 6d233820 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dpaa: no need to make sure all CPUs receive a corresponding Tx queue 



dpaa_fq_setup() iterates through the &priv->dpaa_fq_list elements
allocated by dpaa_alloc_all_fqs(). This includes a call to:

	if (!dpaa_fq_alloc(dev, 0, dpaa_max_num_txqs(), list, FQ_TYPE_TX))
		goto fq_alloc_failed;

which gives us dpaa_max_num_txqs() elements of FQ_TYPE_TX type.

The code block which we are deleting runs after an earlier iteration
through &priv->dpaa_fq_list. So at the end of this iteration (for which
there is no early break), egress_cnt will be unconditionally equal to
dpaa_max_num_txqs().

In other words, dpaa_alloc_all_fqs() has already allocated TX queues for
all possible CPUs and the maximal number of traffic classes, and we've
already iterated once through them all.

The while() condition is dead code, remove it.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: default avatarMadalin Bucur <madalin.bucur@oss.nxp.com>
Link: https://patch.msgid.link/20240713225336.1746343-5-vladimir.oltean@nxp.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e3672a6d

drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

+0 −11
Original line number Diff line number Diff line
@@ -989,17 +989,6 @@ static int dpaa_fq_setup(struct dpaa_priv *priv, 
		}

	}



	 /* Make sure all CPUs receive a corresponding Tx queue. */

	while (egress_cnt < dpaa_max_num_txqs()) {

		list_for_each_entry(fq, &priv->dpaa_fq_list, list) {

			if (fq->fq_type != FQ_TYPE_TX)

				continue;

			priv->egress_fqs[egress_cnt++] = &fq->fq_base;

			if (egress_cnt == dpaa_max_num_txqs())

				break;

		}

	}



	kfree(channels);



	return 0;