Unverified Commit 6d4618ad authored by Lucas Stach's avatar Lucas Stach Committed by Robert Foss
Browse files

drm/bridge: analogix_dp: remove unused platform power_on_end callback 



This isn't used, but gives the impression of the power on and power off
platform calls being non-symmetrical. Remove the unused callback and
rename the power_on_start to simply power_on.

Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Reviewed-by: default avatarRobert Foss <rfoss@kernel.org>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240619182200.3752465-1-l.stach@pengutronix.de
parent 54be7844

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

+2 −5
Original line number Diff line number Diff line
@@ -1257,8 +1257,8 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp) 
		goto out_dp_clk_pre;

	}



	if (dp->plat_data->power_on_start)

		dp->plat_data->power_on_start(dp->plat_data);

	if (dp->plat_data->power_on)

		dp->plat_data->power_on(dp->plat_data);



	phy_power_on(dp->phy);
@@ -1283,9 +1283,6 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp) 
		goto out_dp_init;

	}



	if (dp->plat_data->power_on_end)

		dp->plat_data->power_on_end(dp->plat_data);



	enable_irq(dp->irq);

	return 0;

drivers/gpu/drm/exynos/exynos_dp.c

+1 −1
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ static int exynos_dp_probe(struct platform_device *pdev) 
	/* The remote port can be either a panel or a bridge */

	dp->plat_data.panel = panel;

	dp->plat_data.dev_type = EXYNOS_DP;

	dp->plat_data.power_on_start = exynos_dp_poweron;

	dp->plat_data.power_on = exynos_dp_poweron;

	dp->plat_data.power_off = exynos_dp_poweroff;

	dp->plat_data.attach = exynos_dp_bridge_attach;

	dp->plat_data.get_modes = exynos_dp_get_modes;

drivers/gpu/drm/rockchip/analogix_dp-rockchip.c

+2 −2
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ static int rockchip_dp_pre_init(struct rockchip_dp_device *dp) 
	return 0;

}



static int rockchip_dp_poweron_start(struct analogix_dp_plat_data *plat_data)

static int rockchip_dp_poweron(struct analogix_dp_plat_data *plat_data)

{

	struct rockchip_dp_device *dp = pdata_encoder_to_dp(plat_data);

	int ret;
@@ -397,7 +397,7 @@ static int rockchip_dp_probe(struct platform_device *pdev) 
	dp->data = dp_data;

	dp->plat_data.panel = panel;

	dp->plat_data.dev_type = dp->data->chip_type;

	dp->plat_data.power_on_start = rockchip_dp_poweron_start;

	dp->plat_data.power_on = rockchip_dp_poweron;

	dp->plat_data.power_off = rockchip_dp_powerdown;

	dp->plat_data.get_modes = rockchip_dp_get_modes;

include/drm/bridge/analogix_dp.h

+1 −2
Original line number Diff line number Diff line
@@ -29,8 +29,7 @@ struct analogix_dp_plat_data { 
	struct drm_connector *connector;

	bool skip_connector;



	int (*power_on_start)(struct analogix_dp_plat_data *);

	int (*power_on_end)(struct analogix_dp_plat_data *);

	int (*power_on)(struct analogix_dp_plat_data *);

	int (*power_off)(struct analogix_dp_plat_data *);

	int (*attach)(struct analogix_dp_plat_data *, struct drm_bridge *,

		      struct drm_connector *);