Commit 6d48e613 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: Add missing guard in bch2_snapshot_has_children() 



We additionally need to be going inconsistent if passed an invalid
snapshot ID; that patch will need more thorough testing.

Reported-by: default avatar <syzbot+1c9fca23fe478633b305@syzkaller.appspotmail.com>
Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent 6ce26ad3

fs/bcachefs/snapshot.h

+2 −5
Original line number Diff line number Diff line
@@ -176,12 +176,9 @@ static inline bool bch2_snapshot_is_ancestor(struct bch_fs *c, u32 id, u32 ances 


static inline bool bch2_snapshot_has_children(struct bch_fs *c, u32 id)

{

	const struct snapshot_t *t;

	bool ret;



	rcu_read_lock();

	t = snapshot_t(c, id);

	ret = (t->children[0]|t->children[1]) != 0;

	const struct snapshot_t *t = snapshot_t(c, id);

	bool ret = t && (t->children[0]|t->children[1]) != 0;

	rcu_read_unlock();



	return ret;