Commit 6d598e85 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: stmmac: remove unnecessary checks in ethtool eee ops 



Phylink will check whether the MAC supports the LPI methods in
struct phylink_mac_ops, and return -EOPNOTSUPP if the LPI capabilities
are not provided. stmmac doesn't provide LPI capabilities if
priv->dma_cap.eee is not set.

Therefore, checking the state of priv->dma_cap.eee in the ethtool ops
and returning -EOPNOTSUPP is redundant - let phylink handle this.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1umsf0-008vKK-A3@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5883cb32

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

+0 −6
Original line number Diff line number Diff line
@@ -852,9 +852,6 @@ static int stmmac_ethtool_op_get_eee(struct net_device *dev, 
{

	struct stmmac_priv *priv = netdev_priv(dev);



	if (!priv->dma_cap.eee)

		return -EOPNOTSUPP;



	return phylink_ethtool_get_eee(priv->phylink, edata);

}
@@ -863,9 +860,6 @@ static int stmmac_ethtool_op_set_eee(struct net_device *dev, 
{

	struct stmmac_priv *priv = netdev_priv(dev);



	if (!priv->dma_cap.eee)

		return -EOPNOTSUPP;



	return phylink_ethtool_set_eee(priv->phylink, edata);

}