Commit 6d7a87f2 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Sakari Ailus
Browse files

media: i2c: imx290: Fix max gain value 



The gain is expressed in multiple of 0.3dB, as a value between 0.0dB
and 72.0dB. Gains between 0.0dB and 30.0dB (included) apply analog gain
only, higher gains from 30.3dB to 72dB apply additional digital gain.

The maximum gain value is erroneously set to 72. Increase it to 100 to
cover the whole analog gain range. Support for digital gain can be added
separately if needed.

The IMX327 and IMX462 are largely compatible with the IMX290, but have
an analog gain range of 0.0dB to 29.4dB and 42dB of digital gain. When
support for those sensors gets added to the driver, the gain control
should be adjusted accordingly.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarAlexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
parent 827c7e69

drivers/media/i2c/imx290.c

+14 −1
Original line number Diff line number Diff line
@@ -1019,8 +1019,21 @@ static int imx290_probe(struct i2c_client *client) 
	v4l2_ctrl_handler_init(&imx290->ctrls, 5);

	imx290->ctrls.lock = &imx290->lock;



	/*

	 * The sensor has an analog gain and a digital gain, both controlled

	 * through a single gain value, expressed in 0.3dB increments. Values

	 * from 0.0dB (0) to 30.0dB (100) apply analog gain only, higher values

	 * up to 72.0dB (240) add further digital gain. Limit the range to

	 * analog gain only, support for digital gain can be added separately

	 * if needed.

	 *

	 * The IMX327 and IMX462 are largely compatible with the IMX290, but

	 * have an analog gain range of 0.0dB to 29.4dB and 42dB of digital

	 * gain. When support for those sensors gets added to the driver, the

	 * gain control should be adjusted accordingly.

	 */

	v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,

			  V4L2_CID_GAIN, 0, 72, 1, 0);

			  V4L2_CID_GAIN, 0, 100, 1, 0);



	v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,

			  V4L2_CID_EXPOSURE, 1, IMX290_VMAX_DEFAULT - 2, 1,