Commit 6d8226cb authored by Alok Tiwari's avatar Alok Tiwari Committed by Miquel Raynal
Browse files

mtd: rawnand: cadence: Fix return type of CDMA send-and-wait helper 



cadence_nand_cdma_send_and_wait() propagates negative errno values
from cadence_nand_cdma_send(), returns -ETIMEDOUT on failure and -EIO
when the CDMA engine reports a command failure.

However, it is declared as u32, causing error codes to wrap.
Change the return type to int to correctly propagate errors.

Fixes: ec4ba01e ("mtd: rawnand: Add new Cadence NAND driver to MTD subsystem")
Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent a75a1dec

drivers/mtd/nand/raw/cadence-nand-controller.c

+1 −1
Original line number Diff line number Diff line
@@ -1066,7 +1066,7 @@ static int cadence_nand_cdma_send(struct cdns_nand_ctrl *cdns_ctrl, 
}



/* Send SDMA command and wait for finish. */

static u32

static int

cadence_nand_cdma_send_and_wait(struct cdns_nand_ctrl *cdns_ctrl,

				u8 thread)

{