Unverified Commit 6d91acc7 authored by David Howells's avatar David Howells Committed by Christian Brauner
Browse files

netfs: Fix partial invalidation of streaming-write folio 

In netfs_invalidate_folio(), if the region of a partial invalidation
overlaps the front (but not all) of a dirty write cached in a streaming
write page (dirty, but not uptodate, with the dirty region tracked by a
netfs_folio struct), the function modifies the dirty region - but
incorrectly as it moves the region forward by setting the start to the
start, not the end, of the invalidation region.

Fix this by setting finfo->dirty_offset to the end of the invalidation
region (iend).

Fixes: cce6bfa6 ("netfs: Fix trimming of streaming-write folios in netfs_inval_folio()")
Closes: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com


Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Link: https://patch.msgid.link/20260512123404.719402-21-dhowells@redhat.com


cc: Paulo Alcantara <pc@manguebit.org>
cc: Matthew Wilcox <willy@infradead.org>
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent dbe55697

fs/netfs/misc.c

+1 −1
Original line number Diff line number Diff line
@@ -262,7 +262,7 @@ void netfs_invalidate_folio(struct folio *folio, size_t offset, size_t length) 
				goto erase_completely;

			/* Move the start of the data. */

			finfo->dirty_len = fend - iend;

			finfo->dirty_offset = offset;

			finfo->dirty_offset = iend;

			trace_netfs_folio(folio, netfs_folio_trace_invalidate_front);

			return;

		}