Commit 6d9b262a authored by Ai Chao's avatar Ai Chao Committed by Hans de Goede
Browse files

platform/x86: hp-wmi: use sysfs_emit() instead of sprintf() 



Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: default avatarAi Chao <aichao@kylinos.cn>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240314063703.315841-1-aichao@kylinos.cn


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 3ff58736

drivers/platform/x86/hp/hp-wmi.c

+6 −6
Original line number Diff line number Diff line
@@ -681,7 +681,7 @@ static ssize_t display_show(struct device *dev, struct device_attribute *attr, 


	if (value < 0)

		return value;

	return sprintf(buf, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



static ssize_t hddtemp_show(struct device *dev, struct device_attribute *attr,
@@ -691,7 +691,7 @@ static ssize_t hddtemp_show(struct device *dev, struct device_attribute *attr, 


	if (value < 0)

		return value;

	return sprintf(buf, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



static ssize_t als_show(struct device *dev, struct device_attribute *attr,
@@ -701,7 +701,7 @@ static ssize_t als_show(struct device *dev, struct device_attribute *attr, 


	if (value < 0)

		return value;

	return sprintf(buf, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



static ssize_t dock_show(struct device *dev, struct device_attribute *attr,
@@ -711,7 +711,7 @@ static ssize_t dock_show(struct device *dev, struct device_attribute *attr, 


	if (value < 0)

		return value;

	return sprintf(buf, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



static ssize_t tablet_show(struct device *dev, struct device_attribute *attr,
@@ -721,7 +721,7 @@ static ssize_t tablet_show(struct device *dev, struct device_attribute *attr, 


	if (value < 0)

		return value;

	return sprintf(buf, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



static ssize_t postcode_show(struct device *dev, struct device_attribute *attr,
@@ -732,7 +732,7 @@ static ssize_t postcode_show(struct device *dev, struct device_attribute *attr, 


	if (value < 0)

		return value;

	return sprintf(buf, "0x%x\n", value);

	return sysfs_emit(buf, "0x%x\n", value);

}



static ssize_t als_store(struct device *dev, struct device_attribute *attr,